Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nextTick timing regression #1573

Merged
merged 2 commits into from May 20, 2020
Merged

fix: nextTick timing regression #1573

merged 2 commits into from May 20, 2020

Conversation

mlrawlings
Copy link
Member

@mlrawlings mlrawlings commented May 19, 2020

Description

We recently updated the nextTick helper to run as a microtask, however the difference in timing from setImmediate has proven to cause some subtle timing issues for a few cases. We're reverting back to setImmediate-like timing using MessageChannel as a fallback which has similar timing properties and works in IE10+ postMessage because MessageChannel is not supported by JSDOM.

Because the AsyncValue was sharing this helper, but relying on it running as a microtask we now have two helpers with fallbacks: queueMicrotask and setImmediate.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@DylanPiercey DylanPiercey merged commit 65ecb6f into master May 20, 2020
DylanPiercey pushed a commit that referenced this pull request May 20, 2020
* fix: nextTick timing regression

(cherry picked from commit 65ecb6f)
@DylanPiercey DylanPiercey deleted the nextTick-timing branch January 26, 2021 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants