Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): expose register taglib api #1583

Merged
merged 1 commit into from Jul 22, 2020

Conversation

DylanPiercey
Copy link
Contributor

Description

Exposes the taglib.register API from the new @marko/compiler api. This allows for registering global, cross translator, taglibs.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1583 into next will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1583   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         211      211           
  Lines        6247     6250    +3     
=======================================
+ Hits         5633     5636    +3     
  Misses        614      614           
Impacted Files Coverage Δ
packages/compiler/src/taglib/index.js 81.81% <100.00%> (+2.87%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75015c6...b143815. Read the comment docs.

@DylanPiercey DylanPiercey merged commit c45c082 into next Jul 22, 2020
@DylanPiercey DylanPiercey deleted the expose-taglib-register-new-compiler branch July 22, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants