Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compiler): use default translator for buildLookup api #1682

Merged
merged 1 commit into from Apr 7, 2021

Conversation

DylanPiercey
Copy link
Contributor

Description

Makes it easier to use compiler.taglib.buildLookup by making the translator argument use the default translator when not provided.

Checklist:

  • I have read the CONTRIBUTING document and have signed (or will sign) the CLA.
  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #1682 (9dab986) into main (94992f2) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 9dab986 differs from pull request most recent head ff31d14. Consider uploading reports for the commit ff31d14 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1682      +/-   ##
==========================================
+ Coverage   90.70%   90.71%   +0.01%     
==========================================
  Files         221      221              
  Lines        6807     6808       +1     
==========================================
+ Hits         6174     6176       +2     
+ Misses        633      632       -1     
Impacted Files Coverage Δ
packages/compiler/src/taglib/index.js 96.96% <100.00%> (+0.09%) ⬆️
packages/compiler/src/util/try-load-translator.js 64.28% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94992f2...ff31d14. Read the comment docs.

@mlrawlings mlrawlings merged commit 0899847 into main Apr 7, 2021
@DylanPiercey DylanPiercey deleted the use-default-translator-build-lookup branch January 8, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants