Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on Windows #679

Closed
StarpTech opened this issue Apr 23, 2017 · 3 comments
Closed

Tests fail on Windows #679

StarpTech opened this issue Apr 23, 2017 · 3 comments
Labels
good first issue Small tasks that would be good for first time contributors help wanted Not on the core-team's roadmap, but it would be great for someone in the community to tackle it status:backlog Tasks planned to be worked on type:bug A bug report

Comments

@StarpTech
Copy link
Contributor

StarpTech commented Apr 23, 2017 •
edited

Windows 10
NodeJs: v7.9.0

Steps

npm install
npm run test

Output

https://gist.github.com/StarpTech/7766ed20349bc4096b647f1dbad2ab0c
@austinkelleher austinkelleher added the type:bug A bug report label Sep 26, 2017
@mlrawlings mlrawlings added the good first issue Small tasks that would be good for first time contributors label Sep 30, 2017
@mlrawlings
Copy link
Member

Looks like our compare helper needs to be updated to normalize line-endings.

Windows uses '\r\n' where as Unix style OS (Linux, Mac) use '\n'.

@mlrawlings mlrawlings added the help wanted Not on the core-team's roadmap, but it would be great for someone in the community to tackle it label Sep 30, 2017
@mlrawlings mlrawlings changed the title Tests doesnt works on Windows Tests fail on Windows Sep 30, 2017
@mlrawlings mlrawlings added the status:backlog Tasks planned to be worked on label Sep 30, 2017
@pajaydev
Copy link
Contributor

@mlrawlings I am facing the same issue. how about using process.platform to check win or mac to fix this issue?. I can give it a try.

@DylanPiercey
Copy link
Contributor

We do not currently have maintainers actively using windows and so it is not a high priority for the test suite to work on windows. (Obviously, Marko itself does need to).

If anyone wants to help us tackle this we'd certainly appreciate it, but as it stands we do not have any plans to address windows support for the test suite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Small tasks that would be good for first time contributors help wanted Not on the core-team's roadmap, but it would be great for someone in the community to tackle it status:backlog Tasks planned to be worked on type:bug A bug report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@StarpTech @mlrawlings @austinkelleher @DylanPiercey @pajaydev