Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix a bug that a delayed micro-frame-slot renders with a non-existing ID #12

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

bill-min
Copy link
Contributor

@bill-min bill-min commented Dec 8, 2022

Description

When a <micro-frame-slot /> renders after <micro-frame-sse /> is already closed and the slotId does not exist in StreamSource, the slot will keep loading until it timeout.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Base: 90.16% // Head: 89.66% // Decreases project coverage by -0.50% ⚠️

Coverage data is based on head (0abcc38) compared to base (d469c64).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
- Coverage   90.16%   89.66%   -0.51%     
==========================================
  Files          16       16              
  Lines         295      300       +5     
  Branches       64       67       +3     
==========================================
+ Hits          266      269       +3     
- Misses          7        9       +2     
  Partials       22       22              
Impacted Files Coverage Δ
...onents/micro-frame-slot/component/web.component.ts 82.05% <0.00%> (-4.44%) ⬇️
...c/components/micro-frame-slot/component/node.marko 91.66% <100.00%> (+0.36%) ⬆️
...components/stream-source/component/StreamSource.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 577ecec into marko-js:main Dec 8, 2022
@github-actions
Copy link

github-actions bot commented Dec 8, 2022

🎉 This PR is included in version 1.4.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants