Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing class and style attributes #17

Merged
merged 10 commits into from
Apr 28, 2023

Conversation

bill-min
Copy link
Contributor

Description

Allow passing class and style attributes to <micro-frame> and <micro-frame-slot> tags which will be applied to the closest <div> inside the tag.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cc259f4) 89.87% compared to head (db315c6) 89.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #17   +/-   ##
=======================================
  Coverage   89.87%   89.87%           
=======================================
  Files          17       17           
  Lines         316      316           
  Branches       68       68           
=======================================
  Hits          284      284           
  Misses         10       10           
  Partials       22       22           
Impacted Files Coverage Δ
...c/components/micro-frame-slot/component/node.marko 94.44% <100.00%> (ø)
...rc/components/micro-frame-slot/component/web.marko 85.71% <100.00%> (ø)
src/components/micro-frame/component/node.marko 81.81% <100.00%> (ø)
src/components/micro-frame/component/web.marko 85.71% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@DylanPiercey DylanPiercey merged commit 23d051b into marko-js:main Apr 28, 2023
4 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants