Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix event type bug and allow custom read to skip events #23

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

bill-min
Copy link
Contributor

Description

  • Fix a bug in parseEvent function that the event type should be in event field, there is no type field in SSE.
  • Add a feature that allow custom read to return undefined where the event should be skipped.

Motivation and Context

Screenshots (if appropriate):

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: +0.05% 🎉

Comparison is base (e9eba7d) 95.65% compared to head (7ae177b) 95.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   95.65%   95.70%   +0.05%     
==========================================
  Files           6        6              
  Lines         161      163       +2     
  Branches       26       27       +1     
==========================================
+ Hits          154      156       +2     
  Misses          2        2              
  Partials        5        5              
Files Changed Coverage Δ
src/util/stream.ts 91.89% <50.00%> (-1.17%) ⬇️
src/components/micro-frame-sse/parser.ts 97.14% <100.00%> (+2.85%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DylanPiercey DylanPiercey merged commit b9e9159 into marko-js:main Aug 10, 2023
5 of 6 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants