Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add common css attributes as props to Grid components #2

Closed
MarkosKon opened this issue Sep 28, 2018 · 1 comment
Closed

Add common css attributes as props to Grid components #2

MarkosKon opened this issue Sep 28, 2018 · 1 comment
Assignees
@MarkosKon
Labels
enhancement New feature or request

Comments

@MarkosKon
Copy link
Owner

It may be useful to add commonly used attributes like bgColor, color, height, width, padding, margin as props to Grid components. It's not perfect but probably better than to extend a Container for example just to add colors. Also note that if you add margin or padding some other props like gutters may break.
@MarkosKon MarkosKon added the enhancement New feature or request label Sep 28, 2018
@MarkosKon MarkosKon self-assigned this Sep 28, 2018
MarkosKon referenced this issue Sep 28, 2018
@MarkosKon
Added color and bgColor properties for Grid components.
d8d4b7a
MarkosKon referenced this issue Sep 28, 2018
@MarkosKon
All the default values that were 'initial' or 'unset' are now null. A…
434c40e 
…dded height property to Grid Components. Added width property to Container and Row. Column has flexWidth. Updated the documentation.
MarkosKon referenced this issue Sep 28, 2018
@MarkosKon
Added margin and padding properties for Grid components. Also updated…
6368c48 
… the documentation.
@MarkosKon
Copy link
Owner Author

This issue is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkosKon MarkosKon

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarkosKon