Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase test coverage to > 80% #2

Closed
markphelps opened this issue Feb 19, 2019 · 5 comments
Closed

Increase test coverage to > 80% #2

markphelps opened this issue Feb 19, 2019 · 5 comments
Labels
good first issue

Comments

@markphelps
Copy link
Collaborator

Increase aggregate test coverage to > 80%
u5surf added a commit to u5surf/flipt that referenced this issue Feb 20, 2019
@u5surf
Increase test coverage in flag_test.go flipt-io#2
3e56ef6
@u5surf
Copy link

u5surf commented Feb 20, 2019

@markphelps
I would like to try this issue.
At fast, coverage is lesser than 70% would be increased.

wip:
server/flag_test.go
server/rule_test.go
server/flag_test.go

@markphelps
Copy link
Collaborator Author

Awesome! I appreciate the help @u5surf !

u5surf added a commit to u5surf/flipt that referenced this issue Feb 20, 2019
@u5surf
Increase test coverage in flag_test.go flipt-io#2
d978642
u5surf added a commit to u5surf/flipt that referenced this issue Feb 21, 2019
@u5surf
Increase test coverage in flag_test.go flipt-io#2
94e2f00
u5surf added a commit to u5surf/flipt that referenced this issue Feb 21, 2019
@u5surf
Increase test coverage in rule_test.go flipt-io#2
5b853cc
u5surf added a commit to u5surf/flipt that referenced this issue Feb 21, 2019
@u5surf
Increase test coverage in rule_test.go flipt-io#2
ea03c4d
u5surf added a commit to u5surf/flipt that referenced this issue Feb 21, 2019
@u5surf
Increase test coverage in rule_test.go flipt-io#2
308b666
u5surf added a commit to u5surf/flipt that referenced this issue Feb 21, 2019
@u5surf
Increase test coverage in segment_test.go flipt-io#2
6b85f28
u5surf added a commit to u5surf/flipt that referenced this issue Feb 22, 2019
@u5surf
Increase test coverage in storage/segment_test.go flipt-io#2
f364927
@markphelps
Copy link
Collaborator Author

Hey @u5surf , I noticed your build seems to be failing on Travis because of the import paths not matching the expected: github.com/markphelps/flipt. I think it's because you forked the repo and cloned to your own path.

You may want to checkout https://medium.com/@sasom/how-to-fork-go-packages-f863e370bbb6

Hope that helps!

u5surf added a commit to u5surf/flipt that referenced this issue Feb 24, 2019
@u5surf
Add go_import_path in .travis.yml flipt-io#2
f8fc572
@u5surf
Copy link

u5surf commented Feb 25, 2019

@markphelps
I added https://docs.travis-ci.com/user/languages/go/#go-import-path, then travis build was done.

u5surf added a commit to u5surf/flipt that referenced this issue Feb 27, 2019
@u5surf
Increase test coverage in storage/rule_test.go flipt-io#2
653e1dc
@markphelps
Copy link
Collaborator Author

Awesome, feel free to submit a PR and I can help with any merge conflicts. Sorry I renamed some things :(

@u5surf u5surf mentioned this issue Feb 28, 2019
Closed
markphelps added a commit that referenced this issue Mar 1, 2019
@markphelps
Merge branch 'issue-2' of git://github.com/u5surf/flipt into u5surf-i…
de22cd8 
…ssue-2

* 'issue-2' of git://github.com/u5surf/flipt:
  Increase test coverage in storage/rule_test.go #2
  Add go_import_path in .travis.yml #2
  Increase test coverage in storage/segment_test.go #2
  Increase test coverage in segment_test.go #2
  Increase test coverage in rule_test.go #2
  Increase test coverage in flag_test.go #2
@markphelps markphelps mentioned this issue Mar 1, 2019
Merged
markphelps added a commit that referenced this issue Mar 1, 2019
@markphelps
U5surf issue 2 (#20)
f41d9e9 
* Increase test coverage in flag_test.go #2

* Increase test coverage in rule_test.go #2

* Increase test coverage in segment_test.go #2

* Increase test coverage in storage/segment_test.go #2

* Add go_import_path in .travis.yml #2

* Increase test coverage in storage/rule_test.go #2

* Update tests
markphelps added a commit that referenced this issue Nov 22, 2023
@erka @markphelps
feat(ui/tokens): delete multiple tokens (#2424)
8a72265 
* feat(ui/tokens): delete multiple tokens

Refs: #2275, FLI-215

* - added delete button per spec
- implemented the logic for multiple tokens deletion
- some ui changes and cleanup

* feat: updates for delete multiple tokens PR

* cleanup selected rows after token deletions

* chore: use existing tokensVersion (#2)

---------

Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markphelps @u5surf