Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix evaluation does not consistently maintain distribution order when using Postgres #233

Merged
merged 6 commits into from
Feb 18, 2020

Conversation

markphelps
Copy link
Collaborator

Fixes: #229

Fix evaluation does not consistently maintain distribution order when using Postgres

* master:
  Mod tidy
  Bump github.com/grpc-ecosystem/grpc-gateway from 1.12.2 to 1.13.0
  Remove space
  Bump github.com/golangci/golangci-lint from 1.23.3 to 1.23.6
@codecov-io
Copy link

codecov-io commented Feb 18, 2020

Codecov Report

Merging #233 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   85.54%   85.55%   +<.01%     
==========================================
  Files          18       18              
  Lines        1681     1682       +1     
==========================================
+ Hits         1438     1439       +1     
  Misses        160      160              
  Partials       83       83
Impacted Files Coverage Δ
storage/db/evaluation.go 79.48% <100%> (+0.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e15381...4341413. Read the comment docs.

@markphelps markphelps merged commit 3d72c28 into master Feb 18, 2020
@markphelps markphelps deleted the issue229 branch February 18, 2020 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Evaluator does not keep distributions order, which makes percentage rollout inconsistent.
2 participants