Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UI] Upgrade packages and engines #625

Merged
merged 21 commits into from Dec 25, 2021
Merged

Conversation

pietdaniel
Copy link
Contributor

@pietdaniel pietdaniel commented Dec 22, 2021

This PR updates the following ui packages:

buefy
 - "^0.8.6"
 + "^0.9.13"
node-sass
 - "^4.14.1"
 + "^6.0.0"
sass-loader
 - "^8.0.0"
 + "^10.1.1"

It also updates the following engines:

node
 - ">= 6.0.0"
 + ">= 16.0.0"
npm
 - ">= 3.0.0"
 + ">= 8.0.0"

Some small changes were made to the webpack.*.conf.js files in order to resolve issues in building locally.

Due to the buefy upgrade, the

<template slot-scope="props">

syntax was no longer valid, being replaced with:

<b-table-column v-slot="props" ...

This PR updates all references to the modern style.

Finally, a lint error on the location of some attributes and the beforeRouteLeave function was resolved.

This PR has been tested and built locally and deployed to a live environment.

@pietdaniel pietdaniel changed the title [UI] Upgrade packages and resolve errors [UI] Upgrade packages and engines Dec 22, 2021
@pietdaniel pietdaniel marked this pull request as ready for review December 22, 2021 22:45
@markphelps
Copy link
Collaborator

Cheers 🍻 @pietdaniel !

I appreciate the help, I'm a noob when it comes to JS and keeping the libs up to date. Def can use help you can provide modernizing the JS

I created a PR against this one to update the node versions in the ITs and locally

@markphelps markphelps enabled auto-merge (squash) December 23, 2021 01:35
auto-merge was automatically disabled December 23, 2021 04:31

Head branch was pushed to by a user without write access

@markphelps markphelps enabled auto-merge (squash) December 23, 2021 21:42
@codecov-commenter
Copy link

codecov-commenter commented Dec 23, 2021

Codecov Report

Merging #625 (364ef14) into master (dea84e0) will not change coverage.
The diff coverage is n/a.

❗ Current head 364ef14 differs from pull request most recent head e2893de. Consider uploading reports for the commit e2893de to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #625   +/-   ##
=======================================
  Coverage   83.43%   83.43%           
=======================================
  Files          16       16           
  Lines        1443     1443           
=======================================
  Hits         1204     1204           
  Misses        207      207           
  Partials       32       32           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dea84e0...e2893de. Read the comment docs.

@markphelps markphelps merged commit 02a8cb0 into flipt-io:master Dec 25, 2021
@markphelps
Copy link
Collaborator

@all-contributors please add @pietdaniel for code

@allcontributors
Copy link
Contributor

@markphelps

I've put up a pull request to add @pietdaniel! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants