Pick best matching test file to switch to when test helpers and stubs are present #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… than jumping to the actual "Tests" file
|
Absolutely! Great work on this, love it! 🌟 💯 |
|
There is another private API behind IDEKit that exposes the file hierarchy that's better suited for this problem. I have a stale branch on one of my development machines that spiked it out but I never got around to implementing it. I'm hoping extensions can handle this in Xcode 8, so we'll see! |
|
Yeah, I wasn't sure if my fix was doing it "the right way" as it's my first dive into Xcode Plug-In development and I didn't want to break anything :) Extensions and Xcode8 sounds definitely interesting! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our codebase at work we use a lot of Stub files that have the same base filename as the source file but are located in the testing target. Depending on their order in the project, Aviator can jump to these Stub files instead of jumping to the Tests file which is annoying.
This fix introduces a ranking for names so that the best matching test file is picked:
1st match: MyClassTests.swift
2nd match: MyClassTestHelper.swift
3rd match: MyClassStub.swift
Do you think this fix is worth pulling into your repo?
Any suggestions?