Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with nodejs 7.4.0 #11

Closed
rod-stuchi opened this issue Jan 17, 2017 · 9 comments
Closed

Doesn't work with nodejs 7.4.0 #11

rod-stuchi opened this issue Jan 17, 2017 · 9 comments

Comments

@rod-stuchi
Copy link

node --version
v7.4.0

markserv

Socket.prototype.__proto__ = EventEmitter.prototype;
                                         ^

TypeError: Cannot read property 'prototype' of undefined
    at Object.<anonymous> (/home/rods/.asdf/installs/nodejs/7.4.0/.npm/lib/node_modules/markserv/node_modules/websocket.io/lib/socket.js:49:42)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/home/rods/.asdf/installs/nodejs/7.4.0/.npm/lib/node_modules/markserv/node_modules/websocket.io/lib/protocols/drafts.js:12:14)
    at Module._compile (module.js:571:32)
    at Object.Module._extensions..js (module.js:580:10)
    at Module.load (module.js:488:32)
    at tryModuleLoad (module.js:447:12)
    at Function.Module._load (module.js:439:3)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)

With node 6.9.x works fine.

@F1LT3R
Copy link
Collaborator

F1LT3R commented Jan 18, 2017

Thanks, looking into it.

@F1LT3R
Copy link
Collaborator

F1LT3R commented Jan 18, 2017

The issue also exists in servlr: kavanagh/srvlr#1
It's a known problem in websocket.io: LearnBoost/websocket.io#55
And in robohydra robohydra/robohydra#24

@F1LT3R
Copy link
Collaborator

F1LT3R commented Jan 18, 2017

Fixing this here: F1LT3R/markserv-legacy#1

(This repo is being phased out of action and moved to markserv-legacy in prep for new version of markserv.

@F1LT3R
Copy link
Collaborator

F1LT3R commented Jan 18, 2017

Fixed

@F1LT3R F1LT3R closed this as completed Jan 18, 2017
@F1LT3R
Copy link
Collaborator

F1LT3R commented Jan 18, 2017

@rod-stuchi can you try npm install markserv -g and let me know if this works for you now?

Thanks!

@rod-stuchi
Copy link
Author

Thank you, I've notice that the problem was in one dependencies.

Great work, markserv is awesome!!

@rahul202
Copy link

Hi @rod-stuchi what is the solution? i tried @F1LT3R solution, but it dint work.. Can you please help me out over here.

@rahul202
Copy link

Which module had problem?

@rod-stuchi
Copy link
Author

@rahul202 do you try to upgrade your version of markserv?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants