Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load content from html file #2

Closed
dmanners opened this issue Jul 23, 2020 · 1 comment
Closed

Load content from html file #2

dmanners opened this issue Jul 23, 2020 · 1 comment

Comments

@dmanners
Copy link

We have been using this module in one of our projects and have found it fairly useful to be able to load the content from a file.

For example, we have a module setup that will have our setup files in it and then we have a content service that will do a lookup for a matching file.

        $this->block->save([
            'identifier' => 'footer_top',
            'title' => 'Footer Top',
            'content' => $this->contentService->getBlockContent('footer_top'),
            'store_id' => (int) $store->getId()
        ]);

Here the folder structure is:

Setup: Module/Setup/Patch/Data/CreateFooterBlockPatch.php
Content: Module/Setup/Block/footer_top.html

Would this be something you would be interested in seeing contributed back to the module?

@markshust
Copy link
Owner

Hi @dmanners!

I really, really like the concept, but this gave me a whole other idea entirely that would be better suited under a new module. I’ll DM you in a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants