Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

higher maxDaysToShow results in events beeing lost #458

Closed
4 tasks done
itobey opened this issue Jul 14, 2021 · 6 comments
Closed
4 tasks done

higher maxDaysToShow results in events beeing lost #458

itobey opened this issue Jul 14, 2021 · 6 comments
Labels
type/bug Something isn't working

Comments

@itobey
Copy link

itobey commented Jul 14, 2021

Hi, I want my dashboard in Home Assistant to show the next 3 events. So I limit the count maxEventCount: 3. If I set maxDaysToShow: 7 and there are only 2 events in that range - but I want to always display 3 - the logical thing is to just increase it to: maxDaysToShow: 30. If I do that, then events that are already in the next days get lost and some other events are shown. It seems to be not chronological.

Another example:
Today (14.7.) I have the following events:
15.7.: 2 events
16.7.: 1 event
19.7.: 1 event

When using maxDaysToShow: 7 with 3 events only one of the events on 15.7. is shown (and the next 2). But when I limit maxDaysToShow: 5 it shows the 2 events of 15.7. and the one on 16.7. So I'm very positive that this is a sorting issue.

See screenshots for the visuals.

Expected behaviour

The events should always be retrieved and shown in chronological order.

Current behaviour

Some events get lost when increasing the amount of days to look ahead.

Screenshot

image

image

Possible reasons and solutions

I guess it's a chronological issue.

Steps to reproduce

Have some events, display only 3 events and increase the amount of days.

Context

I'm losing data which is annoying.

Custom values

  - type: custom:atomic-calendar-revive
    entities:
      - entity: calendar.default_calendar
    firstDayOfWeek: 1
    maxDaysToShow: 7
    name: Events
    showDate: true
    sortByStartTime: false
    showLocation: false
    showDeclined: false
    showLoader: false
    hideFinishedEvents: false
    showRelativeTime: false
    dateFormat: LL
    showCurrentEventLine: false
    showProgressBar: false
    showWeekDay: true
    showMonth: false
    showDescription: false
    disableEventLink: false
    showNoEventsForToday: false
    showEventIcon: false
    disableLocationLink: false
    showFullDayProgress: false
    showHiddenText: false
    calShowDescription: false
    showLastCalendarWeek: false
    disableCalEventLink: false
    disableCalLocationLink: false
    disableCalLink: true
    dimFinishedEvents: true
    cardHeight: 100%
    maxEventCount: 3

Your environment

Home Assistant Docker Image: homeassistant/home-assistant:2021.6.6
HACS: 1.13.2
Atomic Calender Revive: v4.5.0
The Calendar I'm using is a CalDAV selfhosted: Baikal

Stack trace / logging

Checklist

  • I searched the current issues and the issue is not known.
  • I searched the troubleshooting and there's no fix available for this bug.
  • I searched on Google, YouTube, Reddit and there's no fix.
  • I am mostly sure that the problem is related to the code and isn't my fault.
@marksie1988 marksie1988 added the type/bug Something isn't working label Jul 21, 2021
@marksie1988
Copy link
Collaborator

Thanks for all the information, I will need to test and see what is happening here.

The calendar will now sort all events in date order and then do any filtering so it is interesting that this is happening.

@itobey
Copy link
Author

itobey commented Jul 21, 2021

Then it is indeed a strange behavior for me. I'll be glad to help, if I can do anything or verify further investigations, just give me a message.

@marksie1988
Copy link
Collaborator

Hi there,

I have just taken a look and was unable to reproduce this issue. I have setup test events the same as the examples you sent here, then set the max days and max events, every time it shows 3 events in the correct order.

@goldbowler
Copy link

I have the same issue. Events are lost when filter is applied. Also yesterdays whole days events sometimes shows up day after but greyed out.

@marksie1988
Copy link
Collaborator

@goldbowler please could you provide an example of the events and what is not being shown correctly?

I was unable to reproduce the scenario based on the above information. Could you also supply your config I will then recreate the events in my calendar along with your config to see if I can reproduce the issue.

@marksie1988
Copy link
Collaborator

as there has been no update im closing this one out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants