Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search input searches on keypress instead of on enter key #1306

Closed
Illyism opened this issue Aug 31, 2019 · 2 comments
Closed

Search input searches on keypress instead of on enter key #1306

Illyism opened this issue Aug 31, 2019 · 2 comments

Comments

@Illyism
Copy link
Contributor

Illyism commented Aug 31, 2019

Describe your feature request

The search bar should perform searches on every key press.
Not only when pressing enter.

What problem does this feature solve?

  • You have to press enter to search.
  • Bring up results faster for partial text.
  • Feels more fluid

Additional context [optional]

https://www.loom.com/share/155aad2d9ae24839ae79eb447b570c67
@Illyism Illyism mentioned this issue Aug 31, 2019
Merged
@Illyism
Copy link
Contributor Author

Illyism commented Aug 31, 2019

What is the reason this was on enter? Is the search slow? If so, does it happen with large files or with large directories?

@Illyism
Copy link
Contributor Author

Illyism commented Sep 1, 2019

Merged in #1307

@Illyism Illyism closed this as completed Sep 1, 2019
@ghost ghost mentioned this issue Nov 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Illyism