Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search is not working #2054

Closed
danisztls opened this issue Apr 21, 2020 · 6 comments
Closed

Search is not working #2054

danisztls opened this issue Apr 21, 2020 · 6 comments
Assignees
Labels
🐤 blocked/need info Need more details about this issue or pull request

Comments

@danisztls
Copy link

Description

Search is not working.

Steps to reproduce

Try to search anything.

Expected behavior Search returning keyword related results.

Actual behavior

App error message

spawn /usr/lib/marktext/resources/app.asar.unpacked/node_modules/vscode-ripgrep/bin/rg

stdout

09:55:38.706 › {
  constructor: 'Error',
  errno: 'ENOENT',
  code: 'ENOENT',
  syscall: 'spawn /usr/lib/marktext/resources/app.asar.unpacked/node_modules/vscode-ripgrep/bin/rg',
  path: '/usr/lib/marktext/resources/app.asar.unpacked/node_modules/vscode-ripgrep/bin/rg',
  spawnargs: [
    '--json',       '--fixed-strings',    '--ignore-case',
    '--follow',     '--iglob',            '**/*.markdown',
    '--iglob',      '**/*.markdown/**',   '--iglob',
    '**/*.mdown',   '--iglob',            '**/*.mdown/**',
    '--iglob',      '**/*.mkdn',          '--iglob',
    '**/*.mkdn/**', '--iglob',            '**/*.md',
    '--iglob',      '**/*.md/**',         '--iglob',
    '**/*.mkd',     '--iglob',            '**/*.mkd/**',
    '--iglob',      '**/*.mdwn',          '--iglob',
    '**/*.mdwn/**', '--iglob',            '**/*.mdtxt',
    '--iglob',      '**/*.mdtxt/**',      '--iglob',
    '**/*.mdtext',  '--iglob',            '**/*.mdtext/**',
    '--iglob',      '**/*.text',          '--iglob',
    '**/*.text/**', '--iglob',            '**/*.txt',
    '--iglob',      '**/*.txt/**',        '--',
    'preguiça',     '/home/daniel/Notas'
  ],
  stack: 'Error: spawn /usr/lib/marktext/resources/app.asar.unpacked/node_modules/vscode-ripgrep/bin/rg ENOENT\n' +
    '    at Process.ChildProcess._handle.onexit (internal/child_process.js:264:19)\n' +
    '    at onErrorNT (internal/child_process.js:456:16)\n' +
    '    at processTicksAndRejections (internal/process/task_queues.js:80:21)'
}

System

Mark Text: v0.16.1 (3a6182b)
Node.js: 12.13.0
Electron: 8.2.3
Chromium: 80.0.3987.163
OS: Linux x64 5.4.33-3-MANJARO

@fxha
Copy link
Contributor

fxha commented Apr 23, 2020

Thank you for taking the time to report this issue. I think this is the same issue as in #2055. Please follow the steps there and provide feedback.

@fxha fxha added the 🐤 blocked/need info Need more details about this issue or pull request label Apr 23, 2020
@alerque
Copy link
Contributor

alerque commented Apr 23, 2020

I can replicate this too. Again please assign to me since it seems to be an Arch packaging issue. Alternatively if you don't want packaging issues in this repo at all I'll give you access to migrate them to my AUR packages repo where they could be migrated.

@alerque
Copy link
Contributor

alerque commented Apr 23, 2020

I don't think this is the same issue as #2055. If I run the original bundled electron build unmodified from the upstream build system the issue with the current directory and saved workspace goes away, but this search issue is still present.

@fxha
Copy link
Contributor

fxha commented Apr 23, 2020

If I run the original bundled electron build unmodified from the upstream build system the issue with the current directory and saved workspace goes away, but this search issue is still present.

I don't really understand what you mean by that but vscode-ripgrep has a hard-coded path that points to the executable rg inside the app.asar.unpacked directory like /home/felix/.bin/marktext_dev/resources/app.asar.unpacked/node_modules/vscode-ripgrep/bin/rg.

Edit: The same applies to the error message below as we expect the hunspell dictionary (en-US.bdict) in the resource folder.

I'm getting this same error message in 0.16.1.

Error while installing Hunspell default dictionary. Mark Text resources are corrupted!

@alerque
Copy link
Contributor

alerque commented Apr 23, 2020

This issue is fixed in the 0.16.1-4 package version in the AUR.

@alerque
Copy link
Contributor

alerque commented Apr 23, 2020

Hunspell is a different issue, and not expected it work in the Arch package at this time. Let's track that elsewhere: alerque/aur#2

@fxha fxha closed this as completed Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐤 blocked/need info Need more details about this issue or pull request
Projects
None yet
Development

No branches or pull requests

3 participants