Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tab bar becomes visible when file is opened #2081

Open
brainchild0 opened this issue Apr 30, 2020 · 4 comments
Open

tab bar becomes visible when file is opened #2081

brainchild0 opened this issue Apr 30, 2020 · 4 comments
Labels
🦁 need discuss the issue or PR need to discuss

Comments

@brainchild0
Copy link
Contributor

brainchild0 commented Apr 30, 2020

Description

If the tab bar is hidden and one file is open, then the tab bar becomes visible when a new file is opened in the same window.

Steps to reproduce

  1. Create new window with only one open file.
  2. Hide the tab bar.
  3. Open a new file in the same window.

Expected behavior

Tab bar remains hidden.

Actual behavior

Tab bar becomes visible.

Versions

  • Mark Text: 0.16.1
  • Operating system: Linux Mint 19.2
@fxha
Copy link
Contributor

fxha commented Jun 11, 2020

Thank you for reporting the issue. The described behavior is how it's expected to work because there are more than one tab open. Why did you think we should keep the tabs hidden, the user thinks the first tab disappeared/is lost?

@fxha fxha added the 🐤 blocked/need info Need more details about this issue or pull request label Jun 11, 2020
@brainchild0
Copy link
Contributor Author

brainchild0 commented Jun 11, 2020

If multiple files are open, then the application permits hiding the tab bar and keeping it hidden. Equally, if multiple files are already open, and a new file is opened, then a hidden state of the tab bar is preserved.

Only in the special case that 1) exactly one file is already open, and 2) a second one is then opened, does the application automatically make the tab bar visible.

@fxha
Copy link
Contributor

fxha commented Jun 16, 2020

The reason for this is that you already know that there are multiple tabs hidden but if only one tab exists this is not visible to the user.

@fxha fxha closed this as completed Jun 16, 2020
@brainchild0
Copy link
Contributor Author

brainchild0 commented Jun 16, 2020

I personally find this behavior confusing and nonstandard. Perhaps you would consider keeping the topic open for further comments from users.

I am doubtful that the assumption about what a users knows or does not know in each case is necessarily accurate, meanwhile, a completely straightforward use case is prevented by the current choice of behavior.

@fxha fxha reopened this Jun 16, 2020
@fxha fxha added 🦁 need discuss the issue or PR need to discuss and removed 🐤 blocked/need info Need more details about this issue or pull request labels Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦁 need discuss the issue or PR need to discuss
Projects
None yet
Development

No branches or pull requests

2 participants