Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code block width does not change upon resizing window #2608

Closed
dodedodo opened this issue Jun 26, 2021 · 4 comments · Fixed by #2850
Closed

Code block width does not change upon resizing window #2608

dodedodo opened this issue Jun 26, 2021 · 4 comments · Fixed by #2850

Comments

@dodedodo
Copy link

Describe your feature request

When I resize the marktext window, the document text should reflow to the smaller width.

Current behaviour: when resizing marktext's window, the document width stays the same, and overflows on the right when the window's width is too small. Essentially making that part of the document inaccessible.

What problem does this feature solve? [optional]

I often find myself tiling marktext right next to a browser or code editor for taking notes, or referring back to an existing document (with the sidebar disabled). If marktext would be able to claim less horizontal space, that would make it less obtrusive.

Right now, marktext needs a little less than half the width of a 1080p screen.

@YalandHong
Copy link

Possible dup of #1695

Please try to adjust the percentage in the settings.

@dodedodo
Copy link
Author

dodedodo commented Dec 4, 2021

Thanks for your reply! I do not think this is a duplicate.

The issue you refer to is about making the most use of screen real estate. I'm talking about a text-overflow issue when making the window smaller than ~540px (that number is higher with sidebar enabled).

I've tested this some more, and this issue seems to be specifically triggered by code blocks. An empty code-block resizes just fine, however, a code-block with text inside does not.

Ok

abc

Not ok

abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz abcdefghijklmnopqrstuvwxyz

@YalandHong
Copy link

Reproduced on my Windows 10, with MarkText version 0.16.3.

Bug description: The code block does not change its width when I resize the window, making the editor erea overflow.

image

@YalandHong
Copy link

The title of this issue is not clear. Please consider changing it to Code block width does not change upon resizing window or something like that. Thanks!

@dodedodo dodedodo changed the title Smaller minimum width Code block width does not change upon resizing window Dec 14, 2021
@fxha fxha closed this as completed in #2850 Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants