Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Custom Command as image-uploader #2737

Closed
thep0y opened this issue Dec 5, 2021 · 7 comments
Closed

add Custom Command as image-uploader #2737

thep0y opened this issue Dec 5, 2021 · 7 comments
Labels
🦄 feature request New feature or request

Comments

@thep0y
Copy link

thep0y commented Dec 5, 2021

Describe your feature request

Add Custom Command as image-uploader.

like typora:
屏幕截图 2021-12-05 163838

Test Result:
屏幕截图 2021-12-05 164713

Upload an image:
upload

我不打算提交pr,因为这个仓库已经常年未发布新release了

windows版下载链接:
https://www.aliyundrive.com/s/ta6CS1qsxCi

@YalandHong
Copy link

YalandHong commented Dec 6, 2021

Duplicate of #2687

同时,如果有PR可以修复这个问题,请务必提交。开发者虽然最近很少有时间更新,但情况只是暂时的。并且这个仓库的PR本来就少,开发者仍然会抽空合并PR。更多的PR也可以减轻开发者的负担。感谢支持!

@thep0y
Copy link
Author

thep0y commented Dec 6, 2021

Duplicate of #2687

同时,如果有PR可以修复这个问题,请务必提交。开发者虽然最近很少有时间更新,但情况只是暂时的。并且这个仓库的PR本来就少,开发者仍然会抽空合并PR。更多的PR也可以减轻开发者的负担。感谢支持!

我能看见有合并pr,但一年都没有发布release,合并了pr短期内也没什么用,毕竟不能要求所有使用者都自行编绎吧?

@Indosaram
Copy link

+1 to this change. It can be very handy because I'd rather upload my images directly to my private blog.

@thep0y
Copy link
Author

thep0y commented Dec 12, 2021

+1 to this change. It can be very handy because I'd rather upload my images directly to my private blog.

This is the windows installer compiled after adding Custom Command option, if you are interested, you can try it.
https://www.aliyundrive.com/s/ta6CS1qsxCi

@YalandHong
Copy link

如果有PR可以修复这个问题,请务必提交。开发者虽然最近很少有时间更新,但情况只是暂时的。并且这个仓库的PR本来就少,开发者仍然会抽空合并PR。更多的PR也可以减轻开发者的负担。感谢支持!

我能看见有合并pr,但一年都没有发布release,合并了pr短期内也没什么用,毕竟不能要求所有使用者都自行编绎吧?

开发者的话:#2744 (comment)

我们最近会发布一个小版本更新,修复了一些问题,同时确实我们是在重构编辑器,这是一个比较漫长的过程。

目前,第三方image uploader还不在MarkText的计划中。所以,PR越早提交,问题越有可能早点修复。如果你打算过一段时间再PR也没关系,但用户们就可能要再过好几个版本才能享受到这个功能了。感谢你对MarkText的关注和支持!

@thep0y
Copy link
Author

thep0y commented Dec 21, 2021

目前,第三方image uploader还不在MarkText的计划中。所以,PR越早提交,问题越有可能早点修复。如果你打算过一段时间再PR也没关系,但用户们就可能要再过好几个版本才能享受到这个功能了。感谢你对MarkText的关注和支持!

提交pr了,merge 后再关闭这个 issue 吧。

@fxha
Copy link
Contributor

fxha commented Jan 8, 2022

This feature was implemented in #2100 and will be available in our next release.

@fxha fxha closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦄 feature request New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants