Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify output of new approvals #14

Open
markusressel opened this issue Dec 18, 2020 · 1 comment
Open

Simplify output of new approvals #14

markusressel opened this issue Dec 18, 2020 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@markusressel
Copy link
Owner

markusressel commented Dec 18, 2020

Is your feature request related to a problem? Please describe.
The output of new approval entries is a bit hard to read and contains unnecessary info.

Describe the solution you'd like
Cleanup output:

New image is available for resource homeassistant/home-assistant (2020.12.1 -> 2020.12.1).
Expires: mm/dd hh:mm:ss (Xh Ym Zs)

Note: use local timezone, so no +00:00 etc.
Note2: the full suite of properties should still be shown, but only when directly interacting with the bot

@markusressel markusressel added the enhancement New feature or request label Dec 18, 2020
@markusressel markusressel self-assigned this Dec 18, 2020
@markusressel markusressel changed the title Simplify deadline output Simplify output Dec 18, 2020
@markusressel markusressel changed the title Simplify output Simplify output or new approvals Dec 18, 2020
@markusressel markusressel changed the title Simplify output or new approvals Simplify output of new approvals Dec 18, 2020
@markusressel
Copy link
Owner Author

The above is currently not possible, because the button action uses the message text (specifically the Id and Identifier) to approve or decline approvals. It would be possible to store the Id in the button action data itself, I am not sure if the Identifier is needed as well though, which would exceed the 64 bytes limit of telegram button data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant