High cpu usage after update today

[Pilgrim1379]

I'm on macos Big Sur 11.6 and I updated my zsh addons with zsh pull. Since that, as soon as I start iTerm my macbook fan goes berserk and start spinning full on.

When I disable only zsh-autocomplete the problem goes away.

Any ideas?

[Omoeba]

I'm seeing the same issue using oh-my-zsh to manage plugins.

[Omoeba]

Reverting commit 7b1a81c fixes the issue.

[TonAtLacework]

For every command you seem to spin up a new zsh session. Please fix because this makes the plugin unusable.

[marlonrichert]

Oh, wow! I can see it, too, on my Mac. It's quite insane.

Weird that I didn't see this on Linux. I wonder what's different?

@Omoeba Thanks for identifying the commit. I won't revert it entirely, though. That would be throwing out the baby with the bathwater. Sorry, but I will have to close your PR, unless you can update it rollback only the exact changes that cause the problem.

@ThePreacher No clear idea yet, but I will investigate.

Please fix

As if I would do anything else. 🤪

[Omoeba]

I'm not too familiar with zsh so unfortunately I won't be able to identify the exact problematic changes.

[marlonrichert]

Amazing how just one missing character can wreak so much havoc.

diff --git a/scripts/.autocomplete.async b/scripts/.autocomplete.async
index beae03e..961d3b0 100644
--- a/scripts/.autocomplete.async
+++ b/scripts/.autocomplete.async
@@ -280,7 +280,7 @@ log_functions+=( .autocomplete.async.pty )
     builtin zle .autocomplete.async.pty.completion-widget -w 2> /dev/null
   } always {
     print -rNC1 -- \
-        "$_autocomplete__list_lines" "$_autocomplete__mesg" "$_autocomplete__comp_mesg[@]" '\C-C'
+        "$_autocomplete__list_lines" "$_autocomplete__mesg" "$_autocomplete__comp_mesg[@]" $'\C-C'
     builtin kill $sysparams[pid]
   }
 } 2>>| $_autocomplete__log_pty

[marlonrichert]

@Omoeba Don't worry about it. Identifying the broken commit was already very helpful. 👍🏽

[marlonrichert]

For every command you seem to spin up a new zsh session.

@TonAtLacework They're technically not sessions. They're forked child processes. Without them, we wouldn't be able to do multiple things asynchronously.

[Omoeba]

Amazing how just one missing character can wreak so much havoc.

diff --git a/scripts/.autocomplete.async b/scripts/.autocomplete.async
index beae03e..961d3b0 100644
--- a/scripts/.autocomplete.async
+++ b/scripts/.autocomplete.async
@@ -280,7 +280,7 @@ log_functions+=( .autocomplete.async.pty )
     builtin zle .autocomplete.async.pty.completion-widget -w 2> /dev/null
   } always {
     print -rNC1 -- \
-        "$_autocomplete__list_lines" "$_autocomplete__mesg" "$_autocomplete__comp_mesg[@]" '\C-C'
+        "$_autocomplete__list_lines" "$_autocomplete__mesg" "$_autocomplete__comp_mesg[@]" $'\C-C'
     builtin kill $sysparams[pid]
   }
 } 2>>| $_autocomplete__log_pty

haha it's always the tiniest things that get ya

[marlonrichert]

PS: If you enjoy using my software, please consider sponsoring me. 🙂