Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The term "undo" is used twice #3

Closed
hlascelles opened this issue Nov 16, 2020 · 4 comments
Closed

The term "undo" is used twice #3

hlascelles opened this issue Nov 16, 2020 · 4 comments
Labels
wontfix This will not be worked on

Comments

@hlascelles
Copy link

Great plugin - undo is exactly what I want to use it for (the ^_ version).

However I see from the instructions that hist u is also an "undo". I have now finally got it but I did find it confusing. Maybe change that one to be "rollback" (with letter b) or "revert" (with letter v)?

@marlonrichert
Copy link
Owner

Hm, good point. Thanks for the feedback. I’ll have to think about it.

@marlonrichert
Copy link
Owner

marlonrichert commented Nov 26, 2020

I have considered the options, but I still think undo is the most clear in this context. You wouldn't expect delete, edit, fix and get to mean the same thing in different contexts either, would you?

Although, I do like rollback and revert for this, but if I use those, I don't want those to be b or v. That is too hard to remember. Then I would just like it to be r, but that then leaves the question: What would then be the new name for reload? It could be s for sync, which is one I considered earlier, but it would be slightly misleading, since it's only one way.

One other option could be to rename undo to abort and use a for it. That would parallel the a in Zsh's spelling correction. 🤔

b for back would be another choice.

@marlonrichert
Copy link
Owner

Note, by the way, that just as with other Undo features, you can execute hist u multiple times to go further and further back. So, in that sense, too, undo feels more appropriate to me than revert or roll back.

@hlascelles
Copy link
Author

Yes, I see what you mean. I'll leave it with you... I am only using the hist d and ^_ functionality (a lot!), so you choose. I just thought you'd like to hear a newcomer's perspective 👍.

@marlonrichert marlonrichert added the wontfix This will not be worked on label May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants