Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactions not completely deterministic despite seeding the randomizer #185

Closed
Piedone opened this issue Jan 27, 2022 · 4 comments
Closed

Comments

@Piedone
Copy link

Piedone commented Jan 27, 2022

We seed the randomizer as instructed in the docs as you can see in our code here. Despite this, we observed that the interactions are not completely deterministic, see here.

What is it that we can be missing? Thank you!

@fzaninotto
Copy link
Member

No idea. Did you add custom species / strategies ? Did you use Math.Random in them?

@Piedone
Copy link
Author

Piedone commented Jan 28, 2022

Yes, we do add a custom strategy here and use this list of species. However, all of this just configuring built-in gremlins.js functionality and we don't use any custom randomization logic there.

Do we understand correctly that the randomizer setup here should be enough for deterministic execution (if the given seen is constant, which it is)?

@fzaninotto
Copy link
Member

I'm sorry, as you're rendering JS through a templating system, I can't see the code that you're running. Could you build a self-sufficient repro in Codesandbox?

@Piedone
Copy link
Author

Piedone commented Feb 2, 2022

As it turned out, this wasn't an issue with gremlins.js. Rather, an animation on the site and its varying timing (due to the capabilities of the machine it was executed on) caused flakiness.

Thanks for your help!

@Piedone Piedone closed this as completed Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants