Skip to content
This repository has been archived by the owner on May 4, 2019. It is now read-only.

[Insight] Commented code should not be commited #19

Closed
fzaninotto opened this issue Mar 26, 2014 · 0 comments
Closed

[Insight] Commented code should not be commited #19

fzaninotto opened this issue Mar 26, 2014 · 0 comments

Comments

@fzaninotto
Copy link
Member

in src/app.php, line 25

Commented out code reduces readability and lowers the code confidence for other developers. If it's common usage for debug, it should not be committed. Using a version control system, such code can be safely removed.

    use UrlGeneratorTrait;
}

$app = new PHPCRBrowserApplication();

//$app->register(new SessionServiceProvider());
$app->register(new UrlGeneratorServiceProvider());
$app->register(new TwigServiceProvider(), array(
    'twig.path' => __DIR__.'/../views',
));

Posted from SensioLabsInsight

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant