Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency with material-ui #32

Closed
jeromemacias opened this issue Sep 14, 2016 · 3 comments
Closed

Remove dependency with material-ui #32

jeromemacias opened this issue Sep 14, 2016 · 3 comments

Comments

@jeromemacias
Copy link
Contributor

What about create abstract components where the render method is not defined ?
So we will be able to use them without material-ui style dependency.

For examaple, Pagination could be extended by MaterialPaginationand so we will be able to create BootstrapPagination which render pagination in Bootstrap style.

We can even imagine a "themification" of the admin.

@fzaninotto
Copy link
Member

All the material-ui related stuff is already inside a mui directory, it shouldn't be difficult to make it a standalone component - that's already the long-term goal.

However, before making the installation more complex by asking users to install 2 directories, and before making development more complex by asking developers to synchronize changes on 2 repositories, we'll continue bundling material UI components up to a stable release.

In the meantime, if you want to work on an alternative view (bootstrap?), feel free to submit a PR on this repository.

I'll close the issue as it's already something that we have in mind, but for now, admin-on-rest is material-ui only.

@fzaninotto
Copy link
Member

Now that #1543 is merged, it its completely possible to create a new distribution with bootstrap for instance. \o/

@jeromemacias
Copy link
Contributor Author

Nice job, impressive !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants