Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated sort prop in <DataGridHeaderCell> #5096

Closed
Luwangel opened this issue Jul 29, 2020 · 1 comment
Closed

Remove deprecated sort prop in <DataGridHeaderCell> #5096

Luwangel opened this issue Jul 29, 2020 · 1 comment
Assignees
@jdemangeon
Labels
breaking change

Comments

@Luwangel
Copy link
Contributor

Follows issue #5059 and PR #5094

Is your feature request related to a problem? Please describe.

The renaming has already be done. But we need to remove deprecated props.

The original issue is motivated by the confusion introduced by two similar names (sort in <Datagrid> and sort in <DatagridHeaderCell>) containing different content. The first one contains an object { field: 'id', order: 'ASC' } named sort and the second one { sort: 'id', order: 'ASC' }.

Describe the solution you'd like

Remove sort in favor to field in the <DatagridHeaderCell>.

Files concerned:

  • packages/ra-ui-materialui/src/list/DatagridHeaderCell.js (line 64)
@Luwangel Luwangel added this to the 4.0.0 milestone Jul 29, 2020
@jdemangeon jdemangeon self-assigned this Aug 24, 2020
@jdemangeon jdemangeon mentioned this issue Aug 24, 2020
Closed
@jdemangeon jdemangeon linked a pull request Aug 24, 2020 that will close this issue
Fix Deprecated Sort PropType on DatagridHeaderCell #5182
Closed
@fzaninotto fzaninotto mentioned this issue Apr 13, 2021
Closed
@fzaninotto fzaninotto removed this from the 4.0.0-alpha.1 milestone Jan 3, 2022
@fzaninotto fzaninotto mentioned this issue Jan 10, 2022
Merged
3 tasks
@WiXSL
Copy link
Contributor

WiXSL commented Feb 6, 2022 •
edited

Fixed by #7065

@WiXSL WiXSL closed this as completed Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdemangeon jdemangeon

Labels
breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Deprecated Sort PropType on DatagridHeaderCell marmelab/react-admin
4 participants
@fzaninotto @jdemangeon @Luwangel @WiXSL