Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make it works with UUID #7

Closed
Kmaschta opened this issue Sep 5, 2016 · 3 comments
Closed

Make it works with UUID #7

Kmaschta opened this issue Sep 5, 2016 · 3 comments

Comments

@Kmaschta
Copy link
Contributor

Kmaschta commented Sep 5, 2016

As discussed on a precedent PR about identifier parsing, admin-on-rest doesn't support UUID as entities identifier.
@VaclavSir
Copy link
Contributor

What is the issue with UUID identifiers? I am trying to use UUIDs and I haven't found any problem yet other than the prop type warning on Datagrid.

@Kmaschta
Copy link
Contributor Author

It'll not work with a ReferenceManyField because of a parseInt in its rendering.

bjet007 pushed a commit to bjet007/admin-on-rest that referenced this issue Sep 23, 2016
marmelab#7 Make it works with UUID
3be1b39
@fzaninotto fzaninotto mentioned this issue Sep 26, 2016
Closed
bjet007 pushed a commit to bjet007/admin-on-rest that referenced this issue Oct 4, 2016
marmelab#7 Make it works with UUID
cd7ad32
bjet007 pushed a commit to bjet007/admin-on-rest that referenced this issue Oct 5, 2016
marmelab#7 Add Test to check that number are still supported in Refer…
a387f7e 
…enceManyField
bjet007 pushed a commit to bjet007/admin-on-rest that referenced this issue Oct 5, 2016
marmelab#7 Make it works with UUID
cbc8872
bjet007 added a commit to bjet007/admin-on-rest that referenced this issue Oct 6, 2016
@bjet007
Merge pull request #1 from bjet007/uuid-#7
ca42ded 
Uuid marmelab#7
fzaninotto added a commit that referenced this issue Oct 10, 2016
@fzaninotto
Merge pull request #67 from bjet007/uuid-#7
73399b9 
#7 Make it works with UUID
@fzaninotto
Copy link
Member

Fixed by #67

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fzaninotto @VaclavSir @Kmaschta