Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing 'quill' package dependency #89

Closed
alexborisov opened this issue Oct 12, 2016 · 2 comments
Closed

Missing 'quill' package dependency #89

alexborisov opened this issue Oct 12, 2016 · 2 comments

Comments

@alexborisov
Copy link

alexborisov commented Oct 12, 2016 •
edited

Hey I've just updated to the latest 0.4.0 release and my app now fails to start due to a missing package.json dependency:

Failed to compile.

Error in ./~/admin-on-rest/lib/mui/input/RichTextInput.js
Module not found: 'quill' in [...]/node_modules/admin-on-rest/lib/mui/input

 @ ./~/admin-on-rest/lib/mui/input/RichTextInput.js 31:13-29
@alexborisov alexborisov mentioned this issue Oct 12, 2016
Closed
@Kmaschta
Copy link
Contributor

Since the package quill is heavy and only needed by the RichTextInput, it is referenced as peer dependencies, so that you can install it only if you need it.

@alexborisov
Copy link
Author

ok, however i dont use (or need) RichTextInput anywhere and my app fails to start with the above error anyway.

fzaninotto added a commit that referenced this issue Oct 12, 2016
@fzaninotto
Move quill as dependency
464e6c2 
Closes #89
@fzaninotto fzaninotto mentioned this issue Oct 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexborisov @Kmaschta