Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Confirm's confirmColor passable from DeleteButton #9322

Closed
IAmVisco opened this issue Sep 29, 2023 · 4 comments
Closed

Make Confirm's confirmColor passable from DeleteButton #9322

IAmVisco opened this issue Sep 29, 2023 · 4 comments

Comments

@IAmVisco
Copy link
Contributor

Is your feature request related to a problem? Please describe.
One of our team members expressed a concern that confirm to delete dialog's buttons are both primary color. They asked me if I could make the confirm one red, so I did a dive and apparently Confirm component supports confirmColor prop, but there's no way to pass it from DeleteButton component.

@slax57
Copy link
Contributor

slax57 commented Oct 2, 2023

Thank you for your suggestion.
Indeed it looks like DeleteWithConfirmButton could support the confirmColor prop along with the other Confirm props, without too much trouble.
Would you like to open a PR to add support for this prop?

@IAmVisco
Copy link
Contributor Author

IAmVisco commented Oct 2, 2023

Absolutely. I will see when I have time, hopefully this week.

@IAmVisco
Copy link
Contributor Author

IAmVisco commented Oct 9, 2023

Not sure why merging the PR didn't close this automatically, but should be resolved in 4.15.0.

@IAmVisco IAmVisco closed this as completed Oct 9, 2023
@slax57
Copy link
Contributor

slax57 commented Oct 9, 2023

That's because the PR targeted next, and GH only closes the issues automatically when a PR gets merged to the repo's default branch.
But you were right to close the Issue, I would have done it eventually.
Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants