Add default tableViewController editing / delete support #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 30, 2017 15:49
…ting. Move prepareData lines to a seperate func for re-use
…r / better animations
orff
changed the title
|
Hi @orff, thanks for this suggestion and apologies for the delay. I like this approach - will merge, perform a couple of changes and include in the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specifying a boolean in a new custom init method, it passes along a boolean into the FileListViewController which in turn set allowEditing on the tableView. Where I'm not sure things are going to be super smooth is re-parsing of the files and storage variables in the tableView's commit editing style delegate method. In a future version, this might need to be done on a background thread with an activity view display.