Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add framework archive to release #15

Closed
ky1ejs opened this issue Jan 12, 2016 · 4 comments
Closed

Add framework archive to release #15

ky1ejs opened this issue Jan 12, 2016 · 4 comments

Comments

@ky1ejs
Copy link

ky1ejs commented Jan 12, 2016

All you have to do is:

$ carthage build --no-skip-current
$ carthage archive PhoneNumberKit

Then just upload the .zip in the project root.

This will save a bunch of time on CI server and the like.

@marmelroy
Copy link
Owner

Thanks Kyle.

Personally I don't think offering the pre-built framework is the best way to integrate third-party code. However, I can see how some people would appreciate the option (saving some CI time is appealing).

I'll keep it in mind for the next release.

@ky1ejs
Copy link
Author

ky1ejs commented Jan 12, 2016

Awesome! Thanks you! 😊

I agree, but purely for CI alone it's a massive benefit, especially when you have several dependancies. Building each one, then build and testing your own app easily becomes a 10+ min process.

@marmelroy
Copy link
Owner

Hey Kyle! Doing a little clean up of open issues...

Even though it will dramatically speed up CI, I still think it's best to avoid shipping prebuilt binaries of PhoneNumberKit, at least until Swift has a stable ABI.

From Apple:

It would be dangerous to rely upon binary frameworks that use Swift — especially from third parties. As Swift changes, those frameworks will be incompatible with the rest of your app.
https://developer.apple.com/swift/blog/?id=2

@ky1ejs
Copy link
Author

ky1ejs commented Jun 8, 2016

Yeah that makes sense. I can fork and upload a prebuilt binary to my fork for the CI.

P.S. really good seeing you at NSLondon the other week! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants