-
Notifications
You must be signed in to change notification settings - Fork 797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add framework archive to release #15
Comments
Thanks Kyle. Personally I don't think offering the pre-built framework is the best way to integrate third-party code. However, I can see how some people would appreciate the option (saving some CI time is appealing). I'll keep it in mind for the next release. |
Awesome! Thanks you! 😊 I agree, but purely for CI alone it's a massive benefit, especially when you have several dependancies. Building each one, then build and testing your own app easily becomes a 10+ min process. |
Hey Kyle! Doing a little clean up of open issues... Even though it will dramatically speed up CI, I still think it's best to avoid shipping prebuilt binaries of PhoneNumberKit, at least until Swift has a stable ABI. From Apple:
|
Yeah that makes sense. I can fork and upload a prebuilt binary to my fork for the CI. P.S. really good seeing you at NSLondon the other week! :) |
All you have to do is:
Then just upload the .zip in the project root.
This will save a bunch of time on CI server and the like.
The text was updated successfully, but these errors were encountered: