Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

esm version imports non esm scripts from date-fns #7

Closed
trading-peter opened this issue Jan 25, 2019 · 0 comments · Fixed by #8
Closed

esm version imports non esm scripts from date-fns #7

trading-peter opened this issue Jan 25, 2019 · 0 comments · Fixed by #8

Comments

@trading-peter
Copy link
Contributor

Hi @marnusw,

thanks for your awesome project.

I'm working on a project that only uses es modules and therefore doesn't have a transformation step for other module formats. When I imported date-fns-tz I got an error that some modules don't export a default.

So I investigated and found out that the esm functions don't import from date-fns/esm but from date-fns directly (example: https://github.com/marnusw/date-fns-tz/blob/master/src/zonedTimeToUtc/index.js#L1).

I edited your build script to modify the paths. I hope I got that hole situation right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant