Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sentence-transformers requires rust compiler #10

Closed
danyilq opened this issue Aug 11, 2022 · 3 comments
Closed

Sentence-transformers requires rust compiler #10

danyilq opened this issue Aug 11, 2022 · 3 comments

Comments

@danyilq
Copy link
Contributor

danyilq commented Aug 11, 2022

When trying to install the marqo, sentence-transformers requires the rust compiler to be installed on the system.

@danyilq
Copy link
Contributor Author

danyilq commented Aug 11, 2022

can be fixed by running pip install rust before installation of the package

@jn2clark
Copy link
Contributor

Thanks Danyil! You are correct, the current default behavior is that huggingface will use the rust based tokenizers. We will potentially switch to the python tokenizer as the small batch performance should not be any different and can be switched using a flag as described here https://github.com/huggingface/transformers/blob/v4.21.1/src/transformers/models/auto/tokenization_auto.py#L472. Although, the other consideration is that others may want to use the fast tokenizers (or not be aware) so maybe the install is a better approach

@jn2clark
Copy link
Contributor

jn2clark commented Sep 4, 2022

This has been taken care of after the move to Docker.

@jn2clark jn2clark closed this as completed Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants