[BUG] highlights return types are different for different search methods

[jn2clark]

Describe the bug
The results highlights field has a different return type for the different search methods. LEXICAL returns an empty list while TENSOR returns a dict.
accessed viaresults['hits'][0]['_highlights']
To Reproduce
Steps to reproduce the behavior:

1. Install marqo per readme

import marqo as mq
client = mq.Client()
client.index("my-first-index").add_documents([{'text':'something'}])
client.index("my-first-index").search('something') # _highlights type is a dict
client.index("my-first-index").search('something', search_method='LEXICAL') # _highlights type is a list

Expected behavior
The return types are the same.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS] ubuntu 20.04

[Pouyanpi]

Hi @jn2clark ,

I think the issue is the following line

   res_list.append({**just_doc, "_highlights": []})

I think chaning it to

   res_list.append({**just_doc, "_highlights": {})

will resolve the issue.

is it what you are looking for or I've got it wrong?

p.s.

Also, I think it would be better to define a global constant like _EMP_HIGHLIGHT = {}.

[jn2clark]

Thanks @Pouyanpi ! That sounds like the solution. Do you want to put your solution into a pull request?

[Pouyanpi]

@jn2clark , sure I will open a PR asap.

[jn2clark]

Sounds good.

[farshidz]

This is addressed in Marqo v2