Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination [ENHANCEMENT] #71

Closed
pandu-k opened this issue Sep 20, 2022 · 4 comments
Closed

Pagination [ENHANCEMENT] #71

pandu-k opened this issue Sep 20, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@pandu-k
Copy link
Collaborator

pandu-k commented Sep 20, 2022

Is your feature request related to a problem? Please describe.
It's inconvenient to only have a single page of results. for search queries. For certain use cases, it would be great for end users to scroll through pages of results.

Describe the solution you'd like
Implement an offset parameter to search functions. Limit and offset parameters can then enable scrolling through result pages. offset and limit can be mapped to the backend opensearch pagination parameters from and size.

Describe alternatives you've considered
Returning a large number of documents. Then manually implementing a client-side scroll feature. This is a lot of work, and it means larger memory overhead for clients.

Additional context
Add any other context or screenshots about the feature request here.

@pandu-k pandu-k added the enhancement New feature or request label Sep 20, 2022
@pandu-k
Copy link
Collaborator Author

pandu-k commented Dec 13, 2022

Possible solution:

  • one solution for pagination would be only to allow it for up to 3 fields search, if the pagination token length becomes an issue

@pandu-k
Copy link
Collaborator Author

pandu-k commented Dec 13, 2022

To do: doc

@vicilliar vicilliar changed the title Pagnination [ENHANCEMENT] Pagination [ENHANCEMENT] Dec 21, 2022
@vicilliar
Copy link
Contributor

Will be implemented with: #251

@pandu-k
Copy link
Collaborator Author

pandu-k commented Jan 11, 2023

Implemented in this PR: #251

@pandu-k pandu-k closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants