Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remote cluster in marqo config #8

Closed
danyilq opened this issue Aug 10, 2022 · 2 comments
Closed

remote cluster in marqo config #8

danyilq opened this issue Aug 10, 2022 · 2 comments

Comments

@danyilq
Copy link
Contributor

danyilq commented Aug 10, 2022

Due to osx security localhost doesn't work for me so Im using 127.0.0.1, but marqo considers it as a remote cluster

code from config.py

lowered_url = url.lower()
if "localhost" in lowered_url or "0.0.0.0" in lowered_url:
urllib3.disable_warnings()
self.cluster_is_remote = False

We should consider including 127.0.0.1

local_url_list = ["localhost", "0.0.0.0", "127.0.0.1"]
if [local_url for local_url in local_url_list if local_url in lowered_url]:

@pandu-k
Copy link
Collaborator

pandu-k commented Aug 11, 2022

Thanks for this Danyil! Will add this

@pandu-k
Copy link
Collaborator

pandu-k commented Sep 8, 2022

Hi Danyil, I've implemented this fix a few commits ago:

local_host_markers = ["localhost", "0.0.0.0", "127.0.0.1"]

Thanks for the feedback!

@pandu-k pandu-k closed this as completed Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants