Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher incorrectly handles trailing slashes #195

Closed
jmpurtle opened this issue May 11, 2020 · 0 comments
Closed

Dispatcher incorrectly handles trailing slashes #195

jmpurtle opened this issue May 11, 2020 · 0 comments

Comments

@jmpurtle
Copy link
Contributor

jmpurtle commented May 11, 2020

In development of a MCVE, I discovered that when one attempts to use the built in Object Dispatching mechanism on an url such as '/movies/', Webcore delivers a 404 response and navigating to '/movies' correctly renders as a call.

127.0.0.1 - - [11/May/2020 16:26:23] "GET / HTTP/1.1" 200 13
127.0.0.1 - - [11/May/2020 16:26:29] "GET /movies HTTP/1.1" 200 25
web.app.wcmdb.movie.controller:MoviesController.__call__() takes 1 positional argument but 2 were given
127.0.0.1 - - [11/May/2020 16:26:33] "GET /movies/ HTTP/1.1" 404 0

After some discussion, it appears that the splitting of the provided path occurs twice and the second instance does not handle a case where the split will return a single-element empty string on an empty string split and subsequently passed to RemainderArgsExtension.

amcgregor added a commit that referenced this issue May 11, 2020
amcgregor added a commit that referenced this issue May 12, 2020
Travis failed to report back; CI failures a result of old build nodes and legacy Python versions.
@amcgregor amcgregor added this to Complete in Framework Core Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants