Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MemoryFileSystemTest.readSymlinkLoop() #37

Closed
marschall opened this issue Aug 7, 2014 · 6 comments
Closed

Fix MemoryFileSystemTest.readSymlinkLoop() #37

marschall opened this issue Aug 7, 2014 · 6 comments
Assignees
Milestone

Comments

@marschall
Copy link
Owner

MemoryFileSystemTest#readSymlinkLoop() is failing

@marschall marschall added this to the 0.6.1 milestone Aug 7, 2014
@marschall marschall modified the milestones: 0.6.1, 0.6.2 Sep 8, 2014
@marschall marschall removed this from the 0.6.2 milestone Dec 23, 2014
@ghost
Copy link

ghost commented Jan 2, 2015

does this mean that sym link loop detection is no longer a feature ?

You can (in 0.6.3) create a symlink look e.g. by linking to the parent.

@fge
Copy link
Contributor

fge commented Jan 2, 2015

@OpenCAGE not sure what you mean, but you are supposed to be able to create symlinks to anything; the symlink(2) call doesn't care. It is the reading code which is in charge of loop detection if any.

@marschall
Copy link
Owner Author

@OpenCAGE you're right, I removed it from the feature list

@fge
Copy link
Contributor

fge commented Jan 11, 2015

@marschall that's quite a loss :/ Is there a way to re-introduce it? I was of relying on it for some tests I need to perform for assertj's Path assertions... (see assertj/assertj#303)

@ghost
Copy link

ghost commented Jan 11, 2015

testing for loops is easier during link creation. It might be ok by unix to create loops, but I can't see any positive use case for it.

@fge
Copy link
Contributor

fge commented Jan 11, 2015

@OpenCAGE that's not the problem here; all Unix filesystems allow for it, if memoryfilesystem behaves differently that makes it not suitable as a Unix filesystem!

If you want to shoot yourself in the foot, you can, after all ;)

@marschall marschall self-assigned this Jan 14, 2015
@marschall marschall added this to the 0.6.4 milestone Jan 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants