Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return name AND version? #71

Closed
AlansCodeLog opened this issue Jan 16, 2018 · 2 comments
Closed

Return name AND version? #71

AlansCodeLog opened this issue Jan 16, 2018 · 2 comments

Comments

@AlansCodeLog
Copy link

It would be useful to have the promise return the version as well.

@MarshallOfSound
Copy link
Owner

We simply resolve with what the Electron API gives us BrowserWindow.addDevToolsExtension, if you want the version as well (I don't know why you would need this / care about this) raise a feature request on electron/electron with a solid use case 👍

@AlansCodeLog
Copy link
Author

Due to the auto updating problem it's nice to be able to log Added Extension: ${name} ${version}.

I ended up doing let version = require('electron').BrowserWindow.getDevToolsExtensions()[name].version. Taking a look at the code, it looks like you access getDevToolsExtensions() as well so it shouldn't be a problem, but I forgot you can't return multiple values with Promises. It would require returning an array.

It was just a minor suggestion though. Any news on #28?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants