Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update feathers-shallow-populate #27

Closed
fratzinger opened this issue Apr 27, 2021 · 5 comments
Closed

update feathers-shallow-populate #27

fratzinger opened this issue Apr 27, 2021 · 5 comments

Comments

@fratzinger
Copy link
Sponsor Collaborator

fratzinger commented Apr 27, 2021

See Mattchewone/feathers-shallow-populate#22 from @areiterer

As of ^1.4.0 I come across the same problem as @areiterer figured out. Populating an empty object instead of not setting the item at all, leads to many items in my FeathersVuex which are empty temp records.

Version ^1.2.0 which I used lastly did not behave that way. I'm afraid it's a problem I introduced with my changes. Sorry about that!

Please @marshallswain, it would be really nice if you could make this a feathers-shallow-populate release and update the dependency in feathers-graph-populate to that version.

As always, I highly appreciate your work! Thanks in advance!

@marshallswain
Copy link
Owner

@fratzinger I'm updating the deps, now. Stay tuned for a release number. :)

@fratzinger
Copy link
Sponsor Collaborator Author

whoop whoop. Thank you! :)

@marshallswain
Copy link
Owner

Released as feathers-graph-populate@1.4.1.

@fratzinger
Copy link
Sponsor Collaborator Author

Nice! Thanks again!

@areiterer
Copy link

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants