Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union type of records deserialize incorrectly #129

Closed
MarshalX opened this issue Aug 28, 2023 Discussed in #119 · 1 comment · Fixed by #127
Closed

Union type of records deserialize incorrectly #129

MarshalX opened this issue Aug 28, 2023 Discussed in #119 · 1 comment · Fixed by #127
Assignees
Labels
bug Something isn't working

Comments

@MarshalX
Copy link
Owner

Discussed in #119

Originally posted by Scrxtchy July 27, 2023
I've had this problem for a while and had it swept under the rug for a while. I still cannot think of a solution to this.
When retrieving a post though feed.getposts() if the post has an image, but the post has an embed of another record, the images in the maid record as returned with the type of app.bsky.embed.images#image, which is in contrast to when the Post does not have a record embed, it includes the app.bsky.embed.images#view in the embeds, giving back the impageproxy urls for the media.

I am confused as to why this has happened, as when looking at the network requests on the website, the app.bsky.embed.recordWithMedia#view record type contains both a app.bsky.embed.record#viewRecord to contain the record of the quoted post, as well as the app.bsky.embed.images#view images containing the urls that I have been seeking out

@MarshalX MarshalX added the bug Something isn't working label Aug 28, 2023
@MarshalX MarshalX self-assigned this Aug 28, 2023
@MarshalX
Copy link
Owner Author

MarshalX commented Aug 28, 2023

fixed in 5ae9acf
unit tests were added in 1f84f77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant