Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run a go linter as a GitHub action #5

Closed
reedy opened this issue Nov 9, 2021 · 3 comments
Closed

Run a go linter as a GitHub action #5

reedy opened this issue Nov 9, 2021 · 3 comments

Comments

@reedy
Copy link

reedy commented Nov 9, 2021

For example:

https://github.com/golangci/golangci-lint

https://golangci-lint.run/usage/install/#ci-installation

Filed as part of https://phabricator.wikimedia.org/T292110

@reedy reedy changed the title Run a go linter as GitHub action Run a go linter as a GitHub action Nov 9, 2021
@reedy
Copy link
Author

reedy commented Nov 9, 2021

Can potentially do #4 as part of this issue

@miselico
Copy link
Collaborator

miselico commented Nov 9, 2021

I have now added golangci-lint to the workflow. It did indicate some issues already, most of them seem trivial to fix.
I have not investigated how to run tests with this yet.

@miselico
Copy link
Collaborator

Since 06c4a15 the linter is run as part of the github workflow upon creation of a pull request, merging into main and scheduled once every week on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants