Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disappearing selection #1143

Closed
jk411 opened this issue Oct 7, 2023 · 1 comment
Closed

Disappearing selection #1143

jk411 opened this issue Oct 7, 2023 · 1 comment

Comments

@jk411
Copy link

jk411 commented Oct 7, 2023

Open

vis vis.c

Start "visual-line" mode [Shift-v]
keep pressing [arrow-down] or [ j ] ie. move cursor down

selection disappears when anchor is out of screen
the same happens in "visual-char" mode when cursor lands on empty line

maybe
viev.c: view_coord_get()
if (pos < view->start || (pos >= view->end && !eof)) {...

shoul be
if (pos < view->start || (pos > view->end && !eof)) {...

@rnpnr
Copy link
Collaborator

rnpnr commented Oct 8, 2023

Hi,

I've seen this before as well. It seems like the bug was introduced
in c22b2c2 and its reported 'fix' in 364d212 didn't solve it. I
think it might be time to revert both of those since they cause
more bugs than they fix. Doing so would reintroduce #1074 but that
could very well be a bug elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants