Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete stale branches (at least 7yo or >500cb ones?) #1162

Closed
goyalyashpal opened this issue Jan 24, 2024 · 6 comments
Closed

delete stale branches (at least 7yo or >500cb ones?) #1162

goyalyashpal opened this issue Jan 24, 2024 · 6 comments

Comments

@goyalyashpal
Copy link

goyalyashpal commented Jan 24, 2024

https://github.com/martanne/vis/branches/stale

yo: years old
cb: commits behind



@goyalyashpal goyalyashpal changed the title delete stale branches (at least 7yo & 4yo ones?) delete stale branches (at least 7yo or >500cb ones?) Jan 24, 2024
@ninewise
Copy link
Collaborator

I have a local copy of all of these branches in case we ever need them, but it doesn't really bother me to have them here as well. The 0.8 branch I'd keep anyway, should we ever want to patch something on the 0.8 release.

Is there a downside on having stale branches on github?

@goyalyashpal
Copy link
Author

hi!

» 've a local copy of these branches
awesome

» 0.8 branch i'd keep
yeah, my main concern was for those branches being more than 7 years old; as they only have just 0,1,1,2,4,5,9 commits in them. now, i haven't checked the contents of those commits, but, if single commit content are not ginormously large, then number of commits can easily be dealt with (i.e. important parts merged in, important ones discarded)

» Is there a downside on having stale branches on github?
umh, the only thing is that if someone forks the repo with all the branches, then these branches will get copied.

all in all, no, no downside. just that i was thinking of forking the repo for some reason (oh yeah, recalled it - to just try to build it in my way) when i noticed all these branches.

@goyalyashpal
Copy link
Author

feel free to close as not planned if so 😃

@ninewise
Copy link
Collaborator

ninewise commented Jan 27, 2024

I guess cleaning up a bit cannot hurt. I've taken a closer look at them:

  • text-dump contains a rather interesting debug patch (to export text history as dot to make a graph) so I'll keep that around
  • events contains code to add more events to the LUA API, might still be interesting to pick up
  • sregex I dropped, this was an attempt to integrate sregexes but that project hasn't seen updates in 8 years
  • doc I'm not even sure why this existed so removed
  • selections was empty so removed
  • build fixes things on build which were reimplemented by now
  • configure was an outdated change in build as well
  • coverity_scan was more outdated build changes
  • tis same
  • scintillua I guess could still contain useful stuff until we're up to date with scintillua

@goyalyashpal
Copy link
Author

awesome 😊😇🚀

@goyalyashpal
Copy link
Author

  • was an attempt to integrate sregexes but that project hasn't seen updates in 8 years

how about re2 which is also DFA based

sregexes
A non-backtracking NFA/DFA-based Perl-compatible regex engine matching on large data streams

re2 https://github.com/google/re2
RE2 is a fast, safe, thread-friendly alternative to backtracking regular expression engines like those used in PCRE, Perl, and Python.

i wont think that big tech would mess up a regex engine as well... but these big techs cant be trusted either lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants