Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom WebView2 wrapper to show help articles #1588

Merged
merged 19 commits into from
Nov 27, 2023
Merged

Add custom WebView2 wrapper to show help articles #1588

merged 19 commits into from
Nov 27, 2023

Conversation

marticliment
Copy link
Owner

@marticliment marticliment commented Nov 25, 2023

Add a C#.NET WebView2 wrapper to show help articles instead on showing them on the browser

TODO:

  • getUrl method needs fixing

@raghavdhingra24
Copy link
Contributor

Hi Marti,
I wanted to ask why this approach is being used over Qt's QWebEngineView as it might get harder to maintain in future (Just a speculation)

@marticliment
Copy link
Owner Author

This choice is done because:

  1. QtWebEngineView is bundled with the app and occupie 150+ mb of disk space. It requires updating the app in order to update the engine. Instead, WebView2 is bundled with Windows 10/11, so it does not require to be updated regularly from the app and it only occupies ~6mb.
  2. QtWebEngineView is laggy and is not optimized. WebView2 uses hardware acceleration to smoothen navigation so users can enjoy a faster, more pleasant experience.
  3. This is a test that will serve to see to which extent embedding C#.NET windows on a Qt window is viable and if it works flawlessly. If the results are succesful on this non-critical feature, more parts of the interface may get migrated to WinUI3 windows, in order to provide a better interface.

In theory, maintaining should not be harder as long as Qt does not remove the feature to embed windows given their handle. Moreover, the ability to work with two independent environments (Qt and WebView) means the application is not limited to what Qt can do. In fact, the share interface already uses this method, and as far as I know it has been working without any issue.

@marticliment marticliment changed the title Add webview2 wrapper to show help articles Add custom WebView2 wrapper to show help articles Nov 26, 2023
@marticliment marticliment marked this pull request as ready for review November 27, 2023 11:18
@marticliment marticliment merged commit 9337ef3 into main Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants