-
-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exo2.6.0 #57
Exo2.6.0 #57
Conversation
# Conflicts: # ExoPlayer.Core/ExoPlayer.Core.csproj # ExoPlayer.Core/Transforms/Metadata.xml # ExoPlayer.Dash/ExoPlayer.Dash.csproj # ExoPlayer.Ext.Gvr/Jars/extension-gvr-r2.5.3.aar # ExoPlayer.Ext.Ima/ExoPlayer.Ext.Ima.csproj # ExoPlayer.Ext.Rtmp/Jars/extension-rtmp-2.6.0.aar # ExoPlayer.Ext.Rtmp/Jars/extension-rtmp-r2.5.1.aar # ExoPlayer.Ext.Rtmp/Jars/extension-rtmp-r2.5.3.aar # ExoPlayer.sln # ExoPlayer/ExoPlayer.csproj # nuspec/Xam.Plugins.Android.ExoPlayer.nuspec
// This file is subject to the terms and conditions defined in | ||
// file 'LICENSE.txt', which is part of this source code package. | ||
// | ||
// Copyright (c) 2017, Sylvain Gravel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove the header?
Are all the AAR files updated? And does the sample still work? |
There we go, sorry for the rushed out PR, I'm sometimes afraid I'll just forget to do something. |
The warnings in bindings are way off sometimes, so don't always pay attention to it. I'll see if i can update the rest of the packages. |
Yes exactly, the warnings are usually useless noise which makes it hard to spot the real issues. I usually try to spot the warning that mention that some XPath from metadata.xml can't be found. Anyways, thanks for your time |
It might not include all the latest and greatest features but I was able to get the new Downloader classes working and it's a good starting point. Thanks for these bindings Martijn and take note that the time to update the bindings was paid for by WB.