Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exo2.6.0 #57

Merged
merged 5 commits into from
Nov 27, 2017
Merged

Exo2.6.0 #57

merged 5 commits into from
Nov 27, 2017

Conversation

sylvain-toptal
Copy link

It might not include all the latest and greatest features but I was able to get the new Downloader classes working and it's a good starting point. Thanks for these bindings Martijn and take note that the time to update the bindings was paid for by WB.

# Conflicts:
#	ExoPlayer.Core/ExoPlayer.Core.csproj
#	ExoPlayer.Core/Transforms/Metadata.xml
#	ExoPlayer.Dash/ExoPlayer.Dash.csproj
#	ExoPlayer.Ext.Gvr/Jars/extension-gvr-r2.5.3.aar
#	ExoPlayer.Ext.Ima/ExoPlayer.Ext.Ima.csproj
#	ExoPlayer.Ext.Rtmp/Jars/extension-rtmp-2.6.0.aar
#	ExoPlayer.Ext.Rtmp/Jars/extension-rtmp-r2.5.1.aar
#	ExoPlayer.Ext.Rtmp/Jars/extension-rtmp-r2.5.3.aar
#	ExoPlayer.sln
#	ExoPlayer/ExoPlayer.csproj
#	nuspec/Xam.Plugins.Android.ExoPlayer.nuspec
// This file is subject to the terms and conditions defined in
// file 'LICENSE.txt', which is part of this source code package.
//
// Copyright (c) 2017, Sylvain Gravel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the header?

@martijn00
Copy link
Member

Are all the AAR files updated? And does the sample still work?

@sylvain-toptal
Copy link
Author

There we go, sorry for the rushed out PR, I'm sometimes afraid I'll just forget to do something.
Yes all AARs have been updated and I played back a couple of different videos successfully.
What I didn't do however is dig through the warnings to see if anything was left out for some reason. New extensions have also not been integrated so take this PR as an on-the-spot contribution and thanks again for saving us time.

@martijn00 martijn00 merged commit a028c91 into Baseflow:develop Nov 27, 2017
@martijn00
Copy link
Member

The warnings in bindings are way off sometimes, so don't always pay attention to it. I'll see if i can update the rest of the packages.

@sylvain-toptal
Copy link
Author

Yes exactly, the warnings are usually useless noise which makes it hard to spot the real issues. I usually try to spot the warning that mention that some XPath from metadata.xml can't be found.

Anyways, thanks for your time

@sylvain-toptal sylvain-toptal deleted the Exo2.6.0 branch November 27, 2017 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants