Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_extract_artist_post_title can match on artist name itself #3

Closed
Nedlinin opened this issue Feb 3, 2020 · 1 comment · Fixed by #4
Closed

_extract_artist_post_title can match on artist name itself #3

Nedlinin opened this issue Feb 3, 2020 · 1 comment · Fixed by #4
Labels
enhancement New feature or request
Milestone

Comments

@Nedlinin
Copy link
Collaborator

Nedlinin commented Feb 3, 2020

The function _extract_artist_post_title currently matches based on " -" appearing in the post title. However, this could be within the artist name itself. Look into making this function more robust in the hopes of not hitting false matches.

/r/listentothis currently states there is to be double dashes in the title but experience tells me many users do not follow this and use a single dash so we can't necessarily rely on that.

https://www.reddit.com/r/listentothis/wiki/rules#wiki_title_format.3A_artistname_--_trackname_.5Bgenre_.2F_genres.5D_.28year.29

@Nedlinin Nedlinin added the enhancement New feature or request label Feb 3, 2020
@Nedlinin Nedlinin added this to the Beta Launch milestone Feb 3, 2020
@martijnboers
Copy link
Owner

I would say drop the double dash requirements as only 30% of new submissions known about this rule. I'd rather look at where it goes wrong and adjust regex based on that

martijnboers added a commit that referenced this issue Feb 4, 2020
martijnboers added a commit that referenced this issue Feb 4, 2020
martijnboers added a commit that referenced this issue Feb 4, 2020
martijnboers added a commit that referenced this issue Feb 4, 2020
Nedlinin pushed a commit that referenced this issue Feb 4, 2020
* Extract string templates to separate file

remove some of the visual clutter in the file

* Cleanup LastFM class

Removed unused variables

* Remove constructor from variable assignment

* Use regex for matching artist names

Resolves #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants