Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further expand artist/song title extraction #39

Closed
Nedlinin opened this issue Mar 4, 2020 · 5 comments
Closed

Further expand artist/song title extraction #39

Nedlinin opened this issue Mar 4, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@Nedlinin
Copy link
Collaborator

Nedlinin commented Mar 4, 2020

Found some small issues with artist/song title tests that we might want to try to find a way to pass.

        ('007Bonez feat Adro - Motion [Hip-Hop / Rap] (2019)', '007Bonez feat Adro', None, 'Motion'),

This should be

       ('007Bonez feat Adro - Motion [Hip-Hop / Rap] (2019)', '007Bonez', 'Adro', 'Motion'),

But, worse yet, artists that actually have & in the name are detected as a featured artist. For example:

       'Simon & Garfunkel - The Sound of Silence'

Would list the main artist as Simon and the featured artist as Garfunkel.

Not sure there will be an easy way to solve that second one though.

@Nedlinin Nedlinin added the bug Something isn't working label Mar 4, 2020
@ghost
Copy link

ghost commented Mar 4, 2020

Both of these are unfortunately unsolvable problems, we will have to consider which is the better mistake to make based on seriousness and frequency of occurence in each of the ways they can occur. I do believe adding the additional check for feat is probably worth, idk which is the better option for &

@martijnboers
Copy link
Owner

Stumbled on this while searching online for possible solutions:

https://stackoverflow.com/questions/56084573/parsing-a-song-title-from-r-listentothis-for-an-ifttt-applet

@ghost
Copy link

ghost commented Mar 5, 2020

Stumbled on this while searching online for possible solutions:

https://stackoverflow.com/questions/56084573/parsing-a-song-title-from-r-listentothis-for-an-ifttt-applet

We already have that mostly implemented in the repost PR, from what I can tell it is far more comprehensive than the answers on that stackoverflow, though if there is any specific case feel free to leave a comment on #14

@ghost ghost mentioned this issue Mar 6, 2020
@Nedlinin
Copy link
Collaborator Author

Lots of this was solved in #48 .

some more current failures:

('Floating Points feat. Testing--Last Bloom ', 'Floating Points', 'Testing', 'last bloom'),

@ghost
Copy link

ghost commented Apr 1, 2020

I think this should be closed now as it seems to be solved to the degree that is reasonably possible. If there are future issues with artist/song title extraction we should have a new issue for it

@ghost ghost closed this as completed Apr 1, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants