-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further expand artist/song title extraction #39
Comments
Both of these are unfortunately unsolvable problems, we will have to consider which is the better mistake to make based on seriousness and frequency of occurence in each of the ways they can occur. I do believe adding the additional check for feat is probably worth, idk which is the better option for & |
Stumbled on this while searching online for possible solutions: |
We already have that mostly implemented in the repost PR, from what I can tell it is far more comprehensive than the answers on that stackoverflow, though if there is any specific case feel free to leave a comment on #14 |
Lots of this was solved in #48 . some more current failures:
|
I think this should be closed now as it seems to be solved to the degree that is reasonably possible. If there are future issues with artist/song title extraction we should have a new issue for it |
Found some small issues with artist/song title tests that we might want to try to find a way to pass.
This should be
But, worse yet, artists that actually have & in the name are detected as a featured artist. For example:
Would list the main artist as Simon and the featured artist as Garfunkel.
Not sure there will be an easy way to solve that second one though.
The text was updated successfully, but these errors were encountered: