resolve deprecated problem of pandas #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I got the following warning and make this patch.
/usr/local/lib/python2.7/site-packages/calmap/__init__.py:295: FutureWarning: how in .resample() is deprecated
the new syntax is .resample(...).sum()
# by_day = data.resample('D', how=how)
`data.resample('D', how=how)` is deprecated and use `data.resample('D').sum()` instead.
|
Thanks for the patch @lyltj2010 😃 This is missing two things:
Also, this removes a warning on Pandas 0.18 and up, while it breaks compatibility with versions below that. I think that's a bit too rough. |
|
got it >-_-< |
|
Well, eventually this needs to be fixed so I'll leave this open for tracking the issue. |
martijnvermaat
added a commit
that referenced
this pull request
Dec 14, 2016
Fix the pandas warning (#10)
|
Great patch! |
|
Hi, if this problem still exists and you'd like to create a PR to fix it please direct it to https://github.com/MarvinT/calmap/ |
|
Thank you for your contribution. Unfortunately I don't have the time to maintain this project. As per @MarvinT 's comment, please see https://github.com/MarvinT/calmap/ instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the following warning and make this patch.
/usr/local/lib/python2.7/site-packages/calmap/init.py:295: FutureWarning: how in .resample() is deprecated
the new syntax is .resample(...).sum()
by_day = data.resample('D', how=how)
data.resample('D', how=how)is deprecated and usedata.resample('D').sum()instead.